[alsa-devel] [PATCH] ASoC: simple-card: fix one bug to writing to the platform data

Li.Xiubo at freescale.com Li.Xiubo at freescale.com
Mon Jan 13 10:09:43 CET 2014

Hi Mark, Jean-Francios

> If the original cinfo is not used anymore, the use of its structure to
> handle the card information is not a good idea:
> - almost all cinfo information are in the struct snd_soc_card,
> - this cinfo structure cannot be extended to handle many DAI links,
> - it contains simple-card information which are of no use for the
>   platform caller.
> So, I'd rather have seen:
> - the removal of 'snd_link' and 'snd_card' from the platform interface
>   (struct asoc_simple_card_info),
> - the definition of a local struct simple_card_data containing the
>   struct snd_soc_card and a pointer to an array of fmt/sysclk values
>   (one per DAI link).

@Jean-Francios, apart from this separate issue we're discussing, do you have
any comment on this patch itself?

@Mark, Since what Jean-Francios is concerned by is another issue apart from
this patch itself and being discussed, can you apply the patch?


Best Regards,

More information about the Alsa-devel mailing list