[alsa-devel] [PATCH] ASoC: simple-card: remove snd_link and snd_card from struct asoc_xx_info

Jean-Francois Moine moinejf at free.fr
Mon Jan 13 08:56:48 CET 2014

On Fri, 10 Jan 2014 20:55:57 +0800
Xiubo Li <Li.Xiubo at freescale.com> wrote:

> Whether the dt is used or not, almost all the simple card information
> for the DAI link and sound card are initialized in the simple card driver.
> And for the platform caller, the snd_link and snd_card are of no use, so
> remove it from struct asoc_simple_card_info, and let them to be the simple
> card driver's global data.
> This is also fix one bug about writing to the platform data directly, for
> it should be constant.
> And now only one DAI link is supported for simple card.
> Signed-off-by: Xiubo Li <Li.Xiubo at freescale.com>
> ---
> This patch maybe not very perfect, such as supporting many DAI links, etc.
> And there still need followed patches to fulfil these.


I don't agree your code: you should not use the cinfo anymore, but
rather move the information it contains to the sound card structure.

Then, you use a static variable as the card structure. It is not
possible to extend this table to handle many DAI links, and, as not
re-entrant, the driver cannot create many sound cards.

Ken ar c'hentañ	|	      ** Breizh ha Linux atav! **
Jef		|		http://moinejf.free.fr/

More information about the Alsa-devel mailing list