[alsa-devel] [PATCH] ASoC: fsl-sai: Add device tree nodes and its availiable check

Li.Xiubo at freescale.com Li.Xiubo at freescale.com
Mon Jan 13 07:15:24 CET 2014

> > +	if (!np || !of_device_is_available(np))
> > +		return -ENODEV;
> > +
> I would expect the of_device_is_available() check to be done by the
> driver core rather than by individual drivers - every single driver
> should have that check.  Is this not happening?  The check for np is OK
> though.

Yes, I hasn't found the core driver does that for now...

And IMO this is needed since the SAI driver is only base dts. And maybe
the device is not presently operational, but it might become operational
in the future (for example, something is not plugged in, or switched off).
Or A serious error was detected in the device, and it is unlikely to become
operational without repair...

And for now for the individual drivers, before calling the of_device_is_available
the '!np' check is need, because:
While in __of_device_is_available:
 >	status = of_get_property(device, "status", &statlen);
 >	if (status == NULL)
 >		return 1;
The status value returned from 'of_get_property()' will be NULL in two cases:
Firstly: the 'device' value (device node) is NULL.
Secondly: the 'status' property is actaully not exist.

If the device node is NULL, the __of_device_is_available will return true too,
that will mean the absent state of the 'status' property.


Best Regards,

More information about the Alsa-devel mailing list