[alsa-devel] [PATCH v3 6/6] ASoC: samsung: Remove SND_DMAENGINE_PCM_FLAG_NO_RESIDUE flag

Lars-Peter Clausen lars at metafoo.de
Sat Jan 11 14:02:21 CET 2014

The Samsung dmaengine ASoC driver is used with two different dmaengine drivers.
The pl80x, which properly supports residue reporting and the pl330, which
reports that it does not support residue reporting. So there is no need to
manually set the NO_RESIDUE flag. This has the advantage that a proper (race
condition free) PCM pointer() implementation is used when the pl80x driver is
used. Also once the pl330 driver supports residue reporting the ASoC PCM driver
will automatically start using it.

Signed-off-by: Lars-Peter Clausen <lars at metafoo.de>
No changes since v2
New in v2
 sound/soc/samsung/dmaengine.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/sound/soc/samsung/dmaengine.c b/sound/soc/samsung/dmaengine.c
index 3be479d..750ce58 100644
--- a/sound/soc/samsung/dmaengine.c
+++ b/sound/soc/samsung/dmaengine.c
@@ -68,7 +68,6 @@ int samsung_asoc_dma_platform_register(struct device *dev)
 	return snd_dmaengine_pcm_register(dev, &samsung_dmaengine_pcm_config,

More information about the Alsa-devel mailing list