[alsa-devel] [PATCH] ASoC: simple-card: fix a bug where cinfo will be NULL before using it

Mark Brown broonie at kernel.org
Thu Jan 9 18:37:39 CET 2014

On Thu, Jan 09, 2014 at 05:19:08PM +0800, Xiubo Li wrote:

>  	} else {
> -		cinfo->snd_card.dev = &pdev->dev;
>  		cinfo = pdev->dev.platform_data;
> +		cinfo->snd_card.dev = &pdev->dev;
>  	}

I've applied this since not crashing is good but it's a bug to be
writing to the platform data at all, it should be constant.  If it needs
to be written to a copy should be being used.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20140109/121960bb/attachment.sig>

More information about the Alsa-devel mailing list