[alsa-devel] [PATCH] ASoC: da9055: Partially fix device

Mark Brown broonie at kernel.org
Thu Jan 9 13:13:53 CET 2014

On Thu, Jan 09, 2014 at 11:30:42AM +0000, Opensource [Adam Thomson] wrote:
> On Wed,  8 Jan 2014 20:38:55 +0000, Mark Brown wrote:

Please fix the word wrapping in your mailer to something less than 80
columns, I've reflowed for legibility.

> > Since I don't know which I2C address to use for the CODEC a FIXME has been
> > left in the MFD, this doesn't make anything any worse since the device has
> > never been able to load in the first place.

> What you're saying here is incorrect, as previously discussed at length in this thread:

> http://mailman.alsa-project.org/pipermail/alsa-devel/2013-September/066027.html

> The two drivers did work together fine until someone in 3.12 changed
> the PMIC I2C Id back to just 'da9055' and broke it again. Also, I
> wanted to add a simple patch to tidy up

Hrm, you hadn't mentioned the rename in that thread.  I do note that the
change was from KPIT Cummins who submitted the drivers for this chip for
you guys and appear to be doing updates too...

> the I2C Id names and avoid this but you would not agree. The codec
> part can be standalone and by doing what you've done here means that
> customers would need to now add additional, unnecessary code to be
> able to use just the codec driver.  This is not right to me.

No, users will not have to do any extra work - if anything they have to
do marginally less with only registering one device.  As discussed this
is the way Linux handles things (which is also the rationale in the
changelog for the PMIC rename).  Looking at the changelogs I'd not be
surprised if the rename was done due to the author getting caught out by
the non-standard way the driver was done.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20140109/d0c375de/attachment.sig>

More information about the Alsa-devel mailing list