[alsa-devel] [PATCH] ALSA: compress: add num_sample_rates in snd_codec_desc

[Takashi Iwai]

At Tue, 7 Jan 2014 17:35:10 +0000,
Mark Brown wrote:
> 
> On Tue, Jan 07, 2014 at 09:55:42PM +0530, Vinod Koul wrote:
> 
> >  struct snd_codec_desc {
> >  	__u32 max_ch;
> >  	__u32 sample_rates[MAX_NUM_SAMPLE_RATES];
> > +	__u32 num_sample_rates;
> >  	__u32 bit_rate[MAX_NUM_BITRATES];
> >  	__u32 num_bitrates;
> >  	__u32 rate_control;
> 
> This is adding a field to the userspace ABI which will break it...  not
> sure if we care or not but it probably ought to be noted in the commit
> log at the very least; people do build things like distros with headers
> from older kernels than the ones they run.

The previous commit for sample_rates[] already broke it, so it doesn't
matter for this commit :)  I applied the update patches since
snd_codec_desc isn't used anywhere in the upstream code, and this is
the request from Vinod, so he must know well the ABI regression if it
really matters.


Takashi