[alsa-devel] [PATCH 00/48] Rewrite kernel messages with standard printk helpers

[Takashi Iwai]

At Thu, 27 Feb 2014 16:00:08 +0800,
Raymond Yau wrote:
> 
> > > Hi,
> > > >
> > > > this is another long series of patches for trivial cleanups.
> > > > This time, they replace the printk and snd_print*() calls in ALSA PCI
> > > > and USB drivers with dev_err() and co.  This will give nicer and more
> > > > consistent outputs.
> > > >
> > > > The only drawback by these replacements is that alsa-info.sh won't be
> > > > able to catch the dmesg lines because it doesn't contain any longer
> > > > the word "ALSA", but only show the module name like "snd_intel8x0".
> > > >
> > > > I'm going to fix alsa-info.sh on git soon later, but if you guys think
> > > > "oh no it's disaster!", let me know.  We need to reconsider a better
> > > > way to put the known markers (like explicitly putting "ALSA" at the
> > > > beginning.)
> > > >
> > > >
> > > seem missing au88x0
> >
> > Yes, because some driver codes are horrible to work on.
> > Patches are welcome.
> >
> > > can the driver build as modules in kernel 3.11 (ubuntu 13.10) ?
> >
> > The dev_err() and co exist since ages ago, so it shouldn't be a
> > problem.  These patches, however, need the previous change of
> > snd_card_new() to make the device pointer available in time.
> >
> > No idea about Ubuntu.
> >
> >
> it seem usb-audio failed to build as module since last year
> 
> https://git.kernel.org/cgit/linux/kernel/git/tiwai/sound.git/commit/?id=80ab8eae70e51d578ebbeb228e0f7a562471b8b7

Ah, so you meant alsa-driver tree.  It's unmaintained so far due to
the lack of time.  I really consider dropping it.


Takashi

> 
> 
> all the drivers related to the above patch were no longer build as module
> any more
> 
> 
> 
> copying file alsa-kernel/core/init.c
> Ignoring potentially dangerous file name ../alsa-kernel/core/init.c
> patching file init.c
> Hunk #2 succeeded at 331 (offset 31 lines).
> Hunk #3 succeeded at 363 (offset 31 lines).
> Hunk #4 FAILED at 408.
> Hunk #5 succeeded at 634 (offset 20 lines).
> Hunk #6 FAILED at 666.
> Hunk #7 FAILED at 684.
> Hunk #8 FAILED at 720.
> Hunk #9 FAILED at 728.
> Hunk #10 succeeded at 1013 (offset 19 lines).
> 5 out of 10 hunks FAILED -- saving rejects to file init.c.rej