[alsa-devel] [PATCH 1/1] ALSA: compress: no need to set metadata before next track

Richard Fitzgerald rf at opensource.wolfsonmicro.com
Wed Feb 26 15:54:08 CET 2014

The metadata is mainly for MP3 gapless playback, since
the MP3 audio stream does not contain enough information
to enable gapless. Other audio formats do not necessarily
require any additional metadata so we should allow next_track
to be called without any metadata.

Signed-off-by: Zhao Weijia <weijia.zhao at capelabs.com>
Signed-off-by: Richard Fitzgerald <rf at opensource.wolfsonmicro.com>
 sound/core/compress_offload.c |    6 ------
 1 files changed, 0 insertions(+), 6 deletions(-)

diff --git a/sound/core/compress_offload.c b/sound/core/compress_offload.c
index 7a20897..5a351c7 100644
--- a/sound/core/compress_offload.c
+++ b/sound/core/compress_offload.c
@@ -744,12 +744,6 @@ static int snd_compr_next_track(struct snd_compr_stream *stream)
 	if (stream->runtime->state != SNDRV_PCM_STATE_RUNNING)
 		return -EPERM;
-	/* you can signal next track isf this is intended to be a gapless stream
-	 * and current track metadata is set
-	 */
-	if (stream->metadata_set == false)
-		return -EPERM;
 	retval = stream->ops->trigger(stream, SND_COMPR_TRIGGER_NEXT_TRACK);
 	if (retval != 0)
 		return retval;

More information about the Alsa-devel mailing list