[alsa-devel] [PATCH] ASoC: Intel: sst-acpi: Fix Oops in case of missing firmware

Liam Girdwood liam.r.girdwood at linux.intel.com
Tue Feb 25 15:42:20 CET 2014

On Tue, 2014-02-25 at 16:37 +0200, Jarkko Nikula wrote:
> I swear I tested missing firmware in commit e5161d7987f1 ("ASoC: Intel:
> sst-acpi: Request firmware before SST platform driver probing").
> Unfortunately same wasn't done in commit 6dda27cbbd1d ("ASoC: Intel:
> sst-acpi: Add support for multiple machine drivers per platform") which
> will cause NULL pointer dereference in sst_acpi_fw_cb() when printing the
> error since sst_acpi->mach is not set.
> Fix this obvious error by setting the sst_acpi->mach in sst_acpi_probe().
> Reported-by: Mika Westerberg <mika.westerberg at linux.intel.com>
> Signed-off-by: Jarkko Nikula <jarkko.nikula at linux.intel.com>

Acked-by: Liam Girdwood <liam.r.girdwood at linux.intel.com>

More information about the Alsa-devel mailing list