[alsa-devel] [PATCH 1/4] ASoC: simple-card: Fix device node locks
broonie at kernel.org
Tue Feb 25 13:42:37 CET 2014
On Thu, Feb 20, 2014 at 06:25:12PM +0100, Jean-Francois Moine wrote:
> Some device nodes stay locked and some other ones are not locked
> while being used during the card lifetime.
Please pay more attention to describing your patches clearly in
changelogs and to splitting them up for review. This is a frequent
issue and it does make it much harder to check what's happening.
In this case you're not actually working with locking but rather with
reference counting and there's no real description of the actual errors
either. Saying something like "function X takes a reference which we
need to drop" would help a lot, and it would let us think about if it's
sensible for the function to return holding the reference in the first
place and how long the reference needs to be held for.
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 836 bytes
Desc: Digital signature
More information about the Alsa-devel