[alsa-devel] [patch 2/2] ASoC: sst-haswell-ipc: incorrect sizeof()

Dan Carpenter dan.carpenter at oracle.com
Tue Feb 25 09:33:44 CET 2014

This should be sizeof(pos) instead of sizeof(&pos).  Most likely they
are both 8 bytes though so it doesn't often make a difference in real

Fixes: 22981243589c ('ASoC: Intel: Add Haswell/Broadwell IPC')
Signed-off-by: Dan Carpenter <dan.carpenter at oracle.com>

diff --git a/sound/soc/intel/sst-haswell-ipc.c b/sound/soc/intel/sst-haswell-ipc.c
index 552aebf2c8f5..1f1576a9586a 100644
--- a/sound/soc/intel/sst-haswell-ipc.c
+++ b/sound/soc/intel/sst-haswell-ipc.c
@@ -617,7 +617,7 @@ static void hsw_notification_work(struct work_struct *work)
 		trace_ipc_notification("DSP stream position changed for",
-		sst_dsp_inbox_read(hsw->dsp, pos, sizeof(&pos));
+		sst_dsp_inbox_read(hsw->dsp, pos, sizeof(pos));
 		if (stream->notify_position)
 			stream->notify_position(stream, stream->pdata);

More information about the Alsa-devel mailing list