[alsa-devel] [PATCH] ASoC: Intel: Make sure we only build SST drivers on X86
liam.r.girdwood at linux.intel.com
Wed Feb 19 16:24:21 CET 2014
On Thu, 2014-02-20 at 00:00 +0900, Mark Brown wrote:
> On Wed, Feb 19, 2014 at 02:06:24PM +0000, Liam Girdwood wrote:
> > Disable build on non X86 architectures. This fixes the following build
> > errors on PPC :-
> > sound/soc/intel/sst-dsp.c: In function 'sst_dsp_outbox_write':
> > sound/soc/intel/sst-dsp.c:218:2: error: implicit declaration of function 'memcpy_toio' [-Werror=implicit-function-declaration]
> > memcpy_toio(sst->mailbox.out_base, message, bytes);
> > ^
> But lots of architectures do actually have these operations, I suspect
> looking at some of the existing users depending on PCI is enough if
> excessively strict (this will improve build coverage which tends to be
> useful even if the driver can't be run).
I know that the other architectures will implement their own ops, but no
other architecture other than X86 will have Intel SST.
I can either send a new patch that additionally includes linux/io.h or
send a V2 ?
More information about the Alsa-devel