[alsa-devel] [PATCH 2/4] ASoC: ad193x: Split SPI and I2C code into different modules
broonie at kernel.org
Tue Feb 18 02:06:08 CET 2014
On Mon, Feb 17, 2014 at 01:16:54PM +0100, Lars-Peter Clausen wrote:
> kernel if one of the subsystems is build as a module (Currently only SPI
> can be build as a module).
Same issue again here. You're also going right up to the 80 column
limit here and...
> * The module init path error handling is rather ugly. E.g. what should be
> done if either the SPI or the I2C driver fails to register? Most drivers
> that implement SPI and I2C in the same module currently fallback to
> undefined behavior in that case. Splitting the the driver into two
> modules, one for each bus, allows the registration of the other bus driver
> to continue without problems if one of them fails.
...and something is messed up here, looks like tab/space confusion.
Applied with fixups to the changelog.
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 836 bytes
Desc: Digital signature
More information about the Alsa-devel