[alsa-devel] [PATCH] ASoC: pass snd_soc_jack_gpio to jack_status_check callback

Mark Brown broonie at kernel.org
Tue Feb 18 02:16:52 CET 2014

On Sun, Feb 16, 2014 at 01:36:12PM +0800, xiangxiao wrote:
> so the implementation could get the context data
> Change-Id: I5542613ccf9881deb672e71d0f0c4f603ad761fd

This shouldn't be on upstream patches.

> Signed-off-by: xiangxiao <xiaoxiang at xiaomi.com>

> -	int (*jack_status_check)(void);
> +	int (*jack_status_check)(struct snd_soc_jack_gpio *gpio);

Why is the callback using details of the implementation of
snd_soc_jack_gpio?  Perhaps there's a good reason, I'm not sure and
you've not included any implementation.  I'd have expected to see the
jack able to provide its own context here?
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20140218/ecf5f914/attachment-0001.sig>

More information about the Alsa-devel mailing list