[alsa-devel] [PATCH v5 1/4] ASoC: tlv320aic32x4: Support for master clock

Mark Brown broonie at kernel.org
Tue Feb 18 02:23:29 CET 2014

On Mon, Feb 17, 2014 at 11:04:17AM +0100, Markus Pargmann wrote:

>  Optional properties:
>   - reset-gpios: Reset-GPIO phandle with args as described in gpio/gpio.txt
> + - clocks/clock-names: Clock named 'mclk' for the master clock of the codec.
> +   See clock/clock-bindings.txt for information about the detailed format.

Looking at the code the clock isn't physically optional, why not make it
mandatory?  There's only one mainline user, it looks like it should be
straightforward to update with a fixed clock.

> +	aic32x4->mclk = devm_clk_get(&i2c->dev, "mclk");
> +	if (IS_ERR(aic32x4->mclk))
> +		dev_info(&i2c->dev, "No mclk found, continuing without clock\n");

This is going to break with deferred probe, we need to handle that at
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20140218/3e23417d/attachment.sig>

More information about the Alsa-devel mailing list