[alsa-devel] [PATCH 1/3] ALSA: hda - Remove dependency on bus->pci in hda_beep.c

[Takashi Iwai]

At Sat, 15 Feb 2014 10:17:33 +0100,
Takashi Iwai wrote:
> 
> The default parent device can be obtained directly via card object, so
> we don't need to rely on pci->dev.parent.  Since there is no access to
> pci_dev, we can reduce the inclusion of linux/pci.h, too.
> 
> Signed-off-by: Takashi Iwai <tiwai at suse.de>

I forgot the cover page: these tree patches are trivial cleanups of
hda-codec drivers (not the controller) to work without PCI device
assignment. The idea was triggered by Dylan's question.


Takashi

> ---
>  sound/pci/hda/hda_beep.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/sound/pci/hda/hda_beep.c b/sound/pci/hda/hda_beep.c
> index 0589b39cda6e..d8c437a94559 100644
> --- a/sound/pci/hda/hda_beep.c
> +++ b/sound/pci/hda/hda_beep.c
> @@ -20,7 +20,6 @@
>   */
>  
>  #include <linux/input.h>
> -#include <linux/pci.h>
>  #include <linux/slab.h>
>  #include <linux/workqueue.h>
>  #include <linux/export.h>
> @@ -167,7 +166,7 @@ static int snd_hda_do_attach(struct hda_beep *beep)
>  	input_dev->evbit[0] = BIT_MASK(EV_SND);
>  	input_dev->sndbit[0] = BIT_MASK(SND_BELL) | BIT_MASK(SND_TONE);
>  	input_dev->event = snd_hda_beep_event;
> -	input_dev->dev.parent = &codec->bus->pci->dev;
> +	input_dev->dev.parent = codec->bus->card->dev;
>  	input_set_drvdata(input_dev, beep);
>  
>  	err = input_register_device(input_dev);
> -- 
> 1.8.5.2
> 
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel at alsa-project.org
> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
>