[alsa-devel] [PATCH 2/2] ASoC: fsl-esai: big-endian support

Li.Xiubo at freescale.com Li.Xiubo at freescale.com
Tue Feb 11 08:27:19 CET 2014



> > +  - big-endian : If this property is absent, the native endian mode will
> > +    be in use as default, or the big endian mode will be in use for all the
> > +    device registers.
> 
> > +
> > +
> 
> Single blank line should be enough here :)
> 

This will be removed.


> > @@ -687,6 +688,10 @@ static int fsl_esai_probe(struct platform_device *pdev)
> >  	esai_priv->pdev = pdev;
> >  	strcpy(esai_priv->name, np->name);
> >
> > +	esai_priv->big_endian = of_property_read_bool(np, "big-endian");
> > +	if (esai_priv->big_endian)
> > +		fsl_esai_regmap_config.val_format_endian = REGMAP_ENDIAN_BIG;
> > +
> 
> Same comments here. And please wait for Shawn's reply at the other patch
> before you revise this part to V2.
> 

Okey,


Thanks,

--
Best Regards,
Xiubo


More information about the Alsa-devel mailing list