[alsa-devel] [PATCH] ASoC: pcm512x: Add PCM512x driver

Mark Brown broonie at kernel.org
Thu Feb 6 14:07:35 CET 2014

On Thu, Feb 06, 2014 at 01:51:33PM +0100, Takashi Iwai wrote:
> Mark Brown wrote:

> > +static const char *pcm512x_dsp_program_texts[] = {

> The numbers of items in pcm512x_dsp_program_texts[] and _values[]
> don't match.

Yeah, fixed.

> > +static const struct soc_enum pcm512x_clk_missing =
> > +	SOC_ENUM_SINGLE(PCM512x_CLKDET, 0,  7, pcm512x_clk_missing_text);

> Isn't it 8?

Hrm, it is but this points out an error in the control helpers which has
been there since forever - they call that parameter max but it's not a
maximum, it's the number of elements in the enumeration.  I bet we have
a bunch of other enumerations which miss the last element as a result.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20140206/f236f6e4/attachment.sig>

More information about the Alsa-devel mailing list