[alsa-devel] [PATCH 4/8] regulator: da9055: Add DT support
Opensource [Adam Thomson]
Adam.Thomson.Opensource at diasemi.com
Thu Feb 6 13:22:13 CET 2014
On Thu, Feb 06, 2014 at 12:04:52PM +0000, Mark Brown wrote:
> > Used another driver as an example for this, but if there's a better method
> > then I'm happy to use it. Will have a look.
> That's probably an older driver - the code was factored out at some
> point but lots of drivers don't get much love.
Yep, fair enough. Will sort it.
> What's happening here is that the MFD framework has done the lookup for
> you when passing the interrupt resource through - you should just use
> platform_get_irq_byname() and save a little code in the driver. If it's
> behaving differently on DT and non-DT systems it seems better to figure
> out why and then make it consistent.
Is what I summised but I obviously chose the wrong direction for my fix.
Will use platform_get_irq_byname() solely, and will make sure all works on
both DT and non-DT setups. If not I'll dig further.
More information about the Alsa-devel