[alsa-devel] [PATCH] ASoC: cs42l73: Don't mix SNDRV_PCM_RATE_KNOT with specific rates

Takashi Iwai tiwai at suse.de
Wed Feb 5 08:08:59 CET 2014


At Wed, 05 Feb 2014 10:49:06 +1300,
Eliot Blennerhassett wrote:
> 
> On 05/02/14 10:01, Lars-Peter Clausen wrote:
> > e.g. by a rate list constraint. I find this confusing when casually
> > reading the code. 
> 
> 
> > And this is the only driver that does it.
> 
> A quick grep through the sound tree for "KNOT" shows that there are many
> drivers that do?
> 
> Just a example:
> 
> pci/intel8x0m.c:  .rates = SNDRV_PCM_RATE_8000 | SNDRV_PCM_RATE_16000 |
> SNDRV_PCM_RATE_KNOT
> 
> 
> Do these need 'fixing'?

It would be no "fix" but rather a "cleanup".


Takashi


More information about the Alsa-devel mailing list