[alsa-devel] [PATCH v3 2/5] ASoC: tda998x: add a codec driver for the TDA998x

Lars-Peter Clausen lars at metafoo.de
Tue Feb 4 14:36:50 CET 2014

On 02/04/2014 02:30 PM, Mark Brown wrote:
> What does this actually do?  No information is being passed in to the
> core function here, not even any information on if it's starting or
> stopping.  Looking at the rest of the code I can't help thinking it
> might be clearer to inline this possibly with a lookup helper, the code
> is very small and the lack of parameters makes it hard to follow.
>> +static const struct snd_soc_dapm_route tda_routes[] = {
>> +	{ "hdmi-out", NULL, "HDMI I2S Playback" },
>> +	{ "hdmi-out", NULL, "HDMI SPDIF Playback" },
>> +};

Won't this cause issues with the debugfs widget entries? It's fixable by 
escaping it (replace it by a dash or something) in the debugfs widget 
filename, but I don't think we do this right now.

- Lars

More information about the Alsa-devel mailing list