[alsa-devel] [GIT PULL] ASoC updates for v3.19

Mark Brown broonie at kernel.org
Mon Dec 8 16:53:40 CET 2014


On Mon, Dec 08, 2014 at 04:43:17PM +0100, Takashi Iwai wrote:
> Mark Brown wrote:

> > > For fixing a build error with CONFIG_SND_JACK=n
> > >   sound/soc/codecs/ts3a227e.c:223:2: error: implicit declaration of function ‘snd_jack_set_key’ [-Werror=implicit-function-declaration]

> > The device probably should be ensuring that the jack detection is
> > enabled - the device doesn't do anything except jack detection.

> Yes.  But apart from that, still it's better to have the corresponding
> dummy function, 

That's not always the case - there's some interfaces that should really
only be used by something that really has a strong dependency on the
feature, things will go wrong if the driver thinks the feature is doing
something and it isn't.  This one should be fine though.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: Digital signature
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20141208/9bb9ec58/attachment.sig>


More information about the Alsa-devel mailing list