[alsa-devel] [PATCH v2] ASoC: wm8960: Let wm8960 codec driver manage its own MCLK

Mark Brown broonie at kernel.org
Thu Dec 4 12:25:12 CET 2014


On Thu, Dec 04, 2014 at 04:23:45PM +0800, Zidan Wang wrote:

> If we use PLL to generate sysclk, wm8960_set_dai_pll() will enable PLL. But
> PLL doesn't power down after using codec. So power down PLL in suspend().

That would be a bug in the machine driver, the machine driver should be
disabling the PLL when it suspends since the startup and shutdown of the
PLL need to be coordinated with the input clocks.  Besides, if we were
doing this in the CODEC driver then as I said last time the PLL needs to
be restored on resume since the machine driver should be able to expect
that settings it has made are preserved (eg, if it sets things up on
init).
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: Digital signature
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20141204/defbd5b7/attachment.sig>


More information about the Alsa-devel mailing list