[alsa-devel] [PATCH 21/30] ALSA: oxfw: Change the way to name card

[Takashi Iwai]

At Mon, 01 Dec 2014 08:19:14 +0900,
Takashi Sakamoto wrote:
> 
> On Nov 30 2013 17:31, Takashi Iwai wrote:
> >>> So, this ends up with the identical strings for both driver and
> >>> shortname?  This doesn't sound like an improvement.
> >>
> >> Basically, hard-coded strings can be replaced by strings read from
> >> config-rom on the devices. My original intension of this commit is
> >> following to this.
> >>
> >> But FWSpeakers/FireWave has long strings for vendor/model strings on
> >> config-rom, therefore his commit can obsolete long name only.
> >>
> >> Actually this patch is a help for later patch:
> >> [PATCH 26/30] ALSA: oxfw: Add support for Behringer/Mackie devices
> >> http://mailman.alsa-project.org/pipermail/alsa-devel/2014-November/084818.html
> > 
> > But still it's not applied to LaCie and other that have device_info,
> > no?  So they'll end up with the even shorter names than now.
> >
> > I'd be better to create a short_name from "Vendor Model" where
> > driver_name can be a fallback of model name.
> 
> Any reasons?

Read again: it'll be "shorter name than now".

Basically it's strange to have a very same string for both driver and
shrotname.  The shortname is a more detailed description usually
including both vendor and model names while the driver is the unique
identifier string.

OK?


Takashi