[alsa-devel] ASoC: bug report for ssm2602

[Scott Jiang]

2014-08-22 17:47 GMT+08:00 Lars-Peter Clausen <lars at metafoo.de>:
> On 08/22/2014 11:21 AM, Scott Jiang wrote:
>>
>> Hi Mark and Lars,
>>
>> commit 9d863b88ec371491e926e0828dbe3d36ead0f6f9
>> Author: Lars-Peter Clausen <lars at metafoo.de>
>> Date:   Sat Aug 31 18:15:23 2013 +0200
>>
>>      ASoC: ssm2602: Fix cache sync
>>
>>      The ssm2602 uses regmap for caching not soc-cache, so we need to use
>>      regcache_sync() instead of snd_soc_cache_sync().
>>
>> According my test, regcache_sync() can't recover register values when
>> resume. While snd_soc_cache_sync() works fine. I used regmap_read() to
>> read registers in regmap layer and found it's the same as suspend. But
>> regcache_sync() didn't sync these registers correctly to hardware.
>>
>
> That does not make too much sense. snd_soc_cache_sync() is definitely a
> no-op when using regmap. Which kernel version are you on? Are there any
> additional changes to this driver in your tree?

My version is 3.16. I compared with the latest 3.17 rc2 kernel, there
is only one patch.

commit 00a37032a099572302ae89c893bd5c90b924c537
Author: Mark Brown <broonie at linaro.org>
Date:   Thu Jul 31 12:47:13 2014 +0100

    ASoC: ssm2602: Convert to params_width()

    The CODEC doesn't care how data is laid out in memory.

    Signed-off-by: Mark Brown <broonie at linaro.org>
    Acked-by: Lars-Peter Clausen <lars at metafoo.de>

I believe this patch isn't related to the pm bug here.
By the way, have you ever tested your patches on any blackfin board?
Your patches for adau1761, ssm2602 and bf5xx-i2s all failed to run.

Scott