[alsa-devel] [PATCHv2 1/5] ASoC: fsl-asrc: Convert to use regmap framework's endianness method.

Li.Xiubo at freescale.com Li.Xiubo at freescale.com
Mon Aug 25 04:29:32 CEST 2014


Hi Nicolin,

> > > > diff --git a/sound/soc/fsl/fsl_asrc.c b/sound/soc/fsl/fsl_asrc.c
> > > > index 8221104..3b14531 100644
> > > > --- a/sound/soc/fsl/fsl_asrc.c
> > > > +++ b/sound/soc/fsl/fsl_asrc.c
> > > > @@ -802,10 +802,6 @@ static int fsl_asrc_probe(struct platform_device
> *pdev)
> > > >
> > > >  	asrc_priv->paddr = res->start;
> > > >
> > > > -	/* Register regmap and let it prepare core clock */
> > > > -	if (of_property_read_bool(np, "big-endian"))
> > > > -		fsl_asrc_regmap_config.val_format_endian =
> REGMAP_ENDIAN_BIG;
> > > > -
> > >
> > > What about the binding document? Could we also update that one
> > > since this 'big-endian' is useless?
> > >
> > > Thanks
> > > Nicolin
> >
> > No, the 'big-endian' is very useful still, deleting this because we are
> using
> > The regmap framework's endianness method instead of its own here.
> >
> > And the binding document, as we have discussed days ago, no need to update
> here.
> 
> Okay.. I think I've missed some topic here.
> 

Please refer to the following patches about this:

regmap: add DT endianness binding support.
regmap: Add the DT binding documentation for endianness
And also two of other patches to fix some bugs of these.

Thanks,

BRs
Xiubo



More information about the Alsa-devel mailing list