[alsa-devel] [v4 05/12] ASoC: Intel: mrfld: add bytes control for modules

[Mark Brown]

On Mon, Aug 18, 2014 at 11:06:09AM +0530, Subhransu S. Prusty wrote:
> On Wed, Aug 13, 2014 at 09:00:12PM +0100, Mark Brown wrote:

> > > +	default:
> > > +		pr_err("Invalid Input- algo type:%d\n", bc->type);

> > dev_err().

> We are using pr_err() in all the error conditions for our driver. If it is
> really required to change, we can submit a single patch to change to
> dev_err() once the patches are merged.

Better yet, submit the fix first.  It's definitely better practice not
to use pr_ when you have a device.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20140818/1f15b3bd/attachment.sig>