[alsa-devel] [PATCH] ASoC: rt5645: add clock source selection controls

Mark Brown broonie at kernel.org
Sat Aug 16 15:11:23 CEST 2014


On Thu, Jul 17, 2014 at 05:09:23PM +0800, bardliao at realtek.com wrote:
> From: Bard Liao <bardliao at realtek.com>
> 
> We can select the clock source of some digital widgets in rt5645.
> This patch adds the controls of those selections.

This is exposing the clocking configuration directly to userspace.  I'm
really not sure we should be doing this, it's not how we typically
handle clocking in ASoC - usually the clock management is done in the
kernel as it typically needs to be coordinated with other things such as
clock API operations.  Userspace control tends to be a system level
thing offered by the machine driver.

It's possible that there's a case for doing this directly in userspace
but you need to make it in the changelog.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20140816/8b6b8dcb/attachment.sig>


More information about the Alsa-devel mailing list