[alsa-devel] [PATCH 1/3] ASoC: simple-card: Drop node->name checking

Mark Brown broonie at kernel.org
Thu Apr 24 15:03:41 CEST 2014

On Thu, Apr 24, 2014 at 03:47:59PM +0300, Jyri Sarha wrote:
> On 04/24/2014 02:13 PM, Nicolin Chen wrote:

Please delete unneeded context from your mails...

> >-	if (!strcmp("sound", node->name))
> >-		prefix = "simple-audio-card,";
> >+	prefix = "simple-audio-card,";

> I think you have missed the point of selecting the prefix based on the node
> name.


> Maybe the implementation could have been more explicit, but I think the old
> behavior is more convenient. If we anyway decide to go with this change then
> at least the DT binding document should be updated.

Yes, the implementation needs to be *way* more explicit - I'd expect a
parameter/variable saying which level we're at depending on where we're
at in the parse rather than guessing based on the node name.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20140424/f6ab4d37/attachment.sig>

More information about the Alsa-devel mailing list