[alsa-devel] [PATCH v6] ASoC: add RT286 CODEC driver

Mark Brown broonie at kernel.org
Tue Apr 15 14:04:28 CEST 2014

On Mon, Apr 14, 2014 at 01:59:30PM +0800, bardliao at realtek.com wrote:

> +static unsigned int rt286_hw_read(struct snd_soc_codec *codec,
> +						unsigned int reg)
> +{

> +static int rt286_hw_write(struct snd_soc_codec *codec,
> +				unsigned int reg, unsigned int value)
> +{

To repeat what's been said before if you are implementing register I/O
you *MUST* use regmap to do this.  What's not been clear is if this
device has a control interface that looks enough like a register map to
be implemented like one but since we're just guessing based on a
combination of the code and the HDA spec it's not entirely clear.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20140415/3133bba7/attachment.sig>

More information about the Alsa-devel mailing list