[alsa-devel] [PATCH] ASoC: dapm: don't skip evaluate the power of widget with force set
broonie at kernel.org
Mon Apr 14 22:36:46 CEST 2014
On Sun, Apr 13, 2014 at 04:37:20PM +0800, Xiang Xiao wrote:
> Signed-off-by: Xiang Xiao <xiaoxiang at xiaomi.com>
You should explain why you want to do this in the changelog - what's the
problem that's being fixed or benefit?
> - if (power != peer->power)
> + if (peer->force || power != peer->power)
> dapm_mark_dirty(peer, "peer state change");
This doesn't correspond to your changelog - it *will* skip evaluating
the widget power if the widget is forced. It's not clear why this would
be a benefit.
> - if (w->power == power)
> + if (!w->force && w->power == power)
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 836 bytes
Desc: Digital signature
More information about the Alsa-devel