[alsa-devel] [PATCH] ASoC: rt5640: add rt5639 support

Mark Brown broonie at kernel.org
Tue Apr 8 13:05:43 CEST 2014


On Tue, Apr 08, 2014 at 11:32:09AM +0800, Oder Chiou wrote:

> -static const SOC_ENUM_SINGLE_DECL(rt5640_if1_dac_enum, RT5640_DIG_INF_DATA,
> -				RT5640_IF1_DAC_SEL_SFT, rt5640_data_select);
> +static SOC_ENUM_SINGLE_DECL(rt5640_if1_dac_enum, RT5640_DIG_INF_DATA,
> +	RT5640_IF1_DAC_SEL_SFT, rt5640_data_select);

This seems to contain a lot of changes like this which are purely coding
style changes rather than actual code changes.  As far as I can tell the
majority of this change is coding style or comment changes.  Can you
please split these out into separate commits, it is much harder to
review if it's hard to find the active changes.  There's nothing wrong
with the stylistic stuff particularly but it should be done as separate
changes.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20140408/3ee42e43/attachment.sig>


More information about the Alsa-devel mailing list