[alsa-devel] [PATCH] ASoC: cs42l52: Report correct chip id and revision
brian.austin at cirrus.com
Fri Apr 4 23:50:19 CEST 2014
> On Fri, 4 Apr 2014, Axel Lin wrote:
>> dev_info(&i2c_client->dev, "Cirrus Logic CS42L52, Revision: %02X\n",
>> - reg & 0xFF);
>> + reg & CS42L52_CHIP_REV_MASK);
>> #define CS42L52_CHIP_REV_B0 0x02
>> -#define CS42L52_CHIP_REV_MASK 0x03
>> +#define CS42L52_CHIP_REV_B1 0x03
Correct me if I'm wrong, but it looks like you added CS42L52_CHIP_REV_MASK
and then replaced that define with CS42L52_CHIP_REV_B1?
I think some changes to actually display the correct rev_id based on the
return value of the reg_read would be cool but this isn't it IMO. I don't
think it will be either.
More information about the Alsa-devel