[alsa-devel] [PATCH alsa-lib] pcm: rate: Don't return negative frame count on success in rewind

Andrew Eikum aeikum at codeweavers.com
Fri Apr 4 20:27:25 CEST 2014

snd_pcm_rewind is documented to return <0 on failure and >=0 on

Signed-off-by: Andrew Eikum <aeikum at codeweavers.com>
I checked all other rewind implementations, and this was the only one
that obviously had this bug.

diff --git a/src/pcm/pcm_rate.c b/src/pcm/pcm_rate.c
index 54a3e67..2eb4b1b 100644
--- a/src/pcm/pcm_rate.c
+++ b/src/pcm/pcm_rate.c
@@ -702,7 +702,7 @@ static snd_pcm_sframes_t snd_pcm_rate_rewind(snd_pcm_t *pcm, snd_pcm_uframes_t f
 	n = snd_pcm_rate_move_applptr(pcm, -frames);
-	return n;
+	return n < 0 ? -n : n;
 static snd_pcm_sframes_t snd_pcm_rate_forward(snd_pcm_t *pcm, snd_pcm_uframes_t frames)

More information about the Alsa-devel mailing list