[alsa-devel] [PATCH 0/7] ASoC:davinci-mcasp: bc polarity fix and proper format support

[Daniel Mack]

Hi Peter,

On 04/04/2014 01:31 PM, Peter Ujfalusi wrote:
> The bit clock polarity has been configured incorrectly in the McASP driver for a
> long time. IB_NF, NB_IF and IB_IF was not correct on the receive side since they
> were selecting the same edge as we used for the tx.
> 
> The driver only had support for DSP_B mode (and probably AC97, but I can not
> test that). All other formats were broken (DSP_A, I2S, LEFT_J, etc).

Well, we're using this driver in I2S mode for a number of devices since
a while, so the above statement is not entirely true :)

The cleanups look sane, though. I can test them on AM33xx based hardware
early next week. If you don't want to hold them off until then, no
problem. I can also send fixups in case I spot a regression.

Out of interest: which hardware and which dai format are you testing
this with?


Thanks,
Daniel