[alsa-devel] [PATCH] ASoC: rsnd: SSI needs to prepare clocks before enabling

Ben Dooks ben at trinity.fluff.org
Fri Apr 4 13:42:50 CEST 2014

On Sat, Mar 29, 2014 at 10:09:06AM +0000, Mark Brown wrote:
> On Fri, Mar 28, 2014 at 12:27:06PM +0000, Ben Dooks wrote:
> > From: William Towle <william.towle at codethink.co.uk>
> > 
> > The rsnd_ssi_hw_{stop|start} functions need to call clk_prepare_enable()
> > and clk_disable_unprepare(), otherwise the following warning occurs on
> > attempt to play sound:
> This doesn't apply cleanly against current code, can you please check and
> resend - I can't apply this anyway since...
> > Signed-off-by: William Towle <william.towle at codethink.co.uk>
> > [ben.dooks at codethink.co.uk: add more bug info to report]
> > Tested-by: Ben Dooks <ben.dooks at codethink.co.uk>
> > ---
> ...you forgot to sign off.  I'm also not seeing the debug info you
> mention in the changelog, indeed there's no error checking.


I need to re-do this anyway as we need to prepare the clock separately
from the enable, as the enable code is occasionally being called from
an interrupt context.

I anm not sure what you mean by debug info... there is the log from
the WARN_ON() which is trigger from the clock driver.

Ben Dooks, ben at fluff.org, http://www.fluff.org/ben/

Large Hadron Colada: A large Pina Colada that makes the universe disappear.

More information about the Alsa-devel mailing list