[alsa-devel] [PATCH] ASoC: si476x: Remove custom register I/O implementation

Mark Brown broonie at kernel.org
Sat Sep 28 13:53:46 CEST 2013


On Fri, Sep 27, 2013 at 09:37:01PM -0700, Andrey Smirnov wrote:

> > Since the driver doesn't expose any controls to userspace the only
> > things that can cause register writes are the operations provided by the
> > CODEC driver, they could take the lock for their runtime (which is about
> > the level the v4l stuff is running at AIUI).

> Do you mean moving it to si476x_codec_set_dai_fmt and
> si476x_codec_hw_params? If those are the only two places where
> register read and write are called by SoC sound subsystem then I think
> that would work.

Yes, exactly.  Unless you provide controls or DAPM nothing outside of
the callbacks in your driver is going to interact with registers.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20130928/bcfd3131/attachment.sig>


More information about the Alsa-devel mailing list