[alsa-devel] [PATCH] ASoC: kirkwood: simplify clock handling
Russell King - ARM Linux
linux at arm.linux.org.uk
Tue Sep 24 20:38:43 CEST 2013
On Tue, Sep 24, 2013 at 08:12:35PM +0200, Uwe Kleine-König wrote:
> There is no need to not use extclk if it is identical to the main clk.
> The main motivation for this patch is dropping devm_clk_put which is
> used in a wrong way by all other users.
NAK. There's patches around which switch this driver to always use
the external clock when it's available. This patch prevents that
from happening because we no longer know whether it is the external
clock or not.
What we could do is just lose the reference to the second clock if
it turns out to be idential to the first - it'll get cleaned up if
the driver is unloaded anyway. In other words, the call to
devm_clk_put() here can be viewed as merely an optimisation.
More information about the Alsa-devel