[alsa-devel] [PATCH] ALSA: compress: Fix compress device unregister.

[Takashi Iwai]

At Mon, 16 Sep 2013 09:52:11 +0530,
Vinod Koul wrote:
> 
> On Mon, Sep 16, 2013 at 09:45:01AM +0530, Vinod Koul wrote:
> > On Fri, Sep 13, 2013 at 05:43:17PM +0100, Liam Girdwood wrote:
> > > snd_unregister_device() should return the device type and not stream
> > > direction.
> > Thanks for fixing this, I saw this but didnt get time to fix it.
> > 
> > Acked-By: Vinod Koul <vinod.koul at intel.com>
> > Tested-By: Vinod Koul <vinod.koul at intel.com>
> 
> Also pls CC stable, this fixed would help in older kernels too

I applied this now with these tags, but a pull request to Linus will
be postponed until the next week since I've been traveling now.


thanks,

Takashi

> 
> ~Vinod
> > 
> > Is there a Tested-Acked-??
> > 
> > ~Vinod
> > > 
> > > Signed-off-by: Liam Girdwood <liam.r.girdwood at linux.intel.com>
> > > ---
> > >  sound/core/compress_offload.c | 3 ++-
> > >  1 file changed, 2 insertions(+), 1 deletion(-)
> > > 
> > > diff --git a/sound/core/compress_offload.c b/sound/core/compress_offload.c
> > > index a9ae4f3..fba7e7a 100644
> > > --- a/sound/core/compress_offload.c
> > > +++ b/sound/core/compress_offload.c
> > > @@ -849,7 +849,8 @@ static int snd_compress_dev_disconnect(struct snd_device *device)
> > >  	struct snd_compr *compr;
> > >  
> > >  	compr = device->device_data;
> > > -	snd_unregister_device(compr->direction, compr->card, compr->device);
> > > +	snd_unregister_device(SNDRV_DEVICE_TYPE_COMPRESS, compr->card,
> > > +		compr->device);
> > >  	return 0;
> > >  }
> > >  
> > > -- 
> > > 1.8.1.2
> > > 
> > 
> > -- 
> 
> -- 
>