[alsa-devel] [PATCH v2 2/4] regmap: Add regmap_fields APIs

Mark Brown broonie at kernel.org
Tue Sep 17 14:48:52 CEST 2013

On Sun, Sep 01, 2013 at 08:30:50PM -0700, Kuninori Morimoto wrote:
> Current Linux kernel is supporting regmap_field method
> and it is very useful feature.
> It needs one regmap_filed for one register access.

Applied, thanks.  I did make one update:

> + * A non-zero will be returned when fields access enable,
> + * a zero will be returned in single field.
> + */
> +int regmap_fields_enable(struct regmap_field *field)
> +{
> +	return field->id_size && field->id_offset;
> +}
> +EXPORT_SYMBOL_GPL(regmap_fields_enable);

This seems like it should be something like _is_present() - the name
makes me think it will turn something on, not check that something is
there.  I removed it since it's not used by the following patches and I
didn't notice earlier when I initially looked at the patches during the
merge window.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20130917/e9ed6938/attachment.sig>

More information about the Alsa-devel mailing list