[alsa-devel] [PATCH RFC 2/8] ASoC: davinci-evm: Add device tree binding

Jyri Sarha oku at iki.fi
Wed Sep 11 20:02:06 CEST 2013

On 2013-09-11 14:35, Mark Brown wrote:
> On Wed, Sep 11, 2013 at 01:38:47PM +0300, Jyri Sarha wrote:
> After checking the code, are you sure about this? Non of the other
> codecs have pins in their devicetree binding document?
> Yes, I am sure and yes there are other CODECs with pins listed, check
> again.

I wonder if I somehow misunderstood your first comment. I just
noticed that davinci-evm-audio.txt is missing all the output pins and
some connectors that are found in the code and also in the example
node. I will add those.

I can of course also add the list of pins to Documentation/devicetree/
bindings/sound/tlv320aic3x.txt, if that was what you meant. It would
make sense to have the pins there. However, I really can not find the
list of pins from any of the Wolfson codec binding documents
(Documentation/devicetree/bindings/sound/wm*.txt) for exmaple. Are you
perhaps refering to some other document or is the convention changing
for v3.12?

When comparing the codec bindings I found that the regulators are
missing from tlv320aic3x.txt. I'll add those too.

Best regards,

More information about the Alsa-devel mailing list