[alsa-devel] [PATCH RFC 5/8] ASoC: davinci: Add support for AM33xx SoC Audio

[Mark Brown]

On Mon, Sep 09, 2013 at 06:12:16PM +0300, oku at iki.fi wrote:

>  obj-$(CONFIG_SND_DAVINCI_SOC) += snd-soc-davinci.o
> +obj-$(CONFIG_SND_AM33XX_SOC) += snd-soc-davinci.o
>  obj-$(CONFIG_SND_DAVINCI_SOC_I2S) += snd-soc-davinci-i2s.o
>  obj-$(CONFIG_SND_DAVINCI_SOC_MCASP) += snd-soc-davinci-mcasp.o
> +obj-$(CONFIG_SND_AM33XX_SOC) += snd-soc-davinci-mcasp.o
>  obj-$(CONFIG_SND_DAVINCI_SOC_VCIF) += snd-soc-davinci-vcif.o
>  
>  # DAVINCI Machine Support
>  snd-soc-evm-objs := davinci-evm.o
>  
>  obj-$(CONFIG_SND_DAVINCI_SOC_EVM) += snd-soc-evm.o
> +obj-$(CONFIG_SND_AM33XX_SOC) += snd-soc-evm.o

This appears to be trying to include a duplicate copy of some of the
existing code - that doesn't seem sensible?  I'd expect to see
additional machines added with || and possibly also some help text
updates.

Even better would be to get the code to the point where it has no
machine dependencies at all.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20130909/fe0c021b/attachment.sig>