[alsa-devel] [PATCH v2 0/2][RFC] snd_soc_codec include snd_soc_component
lars at metafoo.de
Tue Sep 3 13:26:50 CEST 2013
On 09/03/2013 03:51 AM, Kuninori Morimoto wrote:
> Hi Mark, Lars
> # Am I missed sending email ??
> # This is re-try
I got the mails from the first try as well.
> This is 2nd version of codec <-> component merge patch.
> Basically, 1st patch is almost same as v1 version,
> but the differences are...
> - "component" moves to upside of "codec" (to avoid extra declaration)
> - register_component had "allow_single_dai" flag
> to control dai/dais function.
> Now, we can keep codec dai name
> 2nd patch adds component_driver on wm8978 (as trial).
> It is not needed at this point, since current component doesn't
> check whether component_driver was NULL.
> But we will need/use it in the future.
> What do you think about this series ?
Looks good to me. I think the only thing missing is a call to
snd_soc_component_unregister() from snd_soc_codec_unregister().
> I can send "use component" patch for all codecs
> if you want me it.
While nice to have I don't think it is a requirement to do this before we
can continue with the changes to the core. So if you want to do it go for
it, but it's also not a problem if it is not done.
More information about the Alsa-devel