[alsa-devel] [PATCH 6/9] ASoC: max98095: Add missing negative channel checks

Mark Brown broonie at kernel.org
Wed Oct 30 17:46:53 CET 2013

On Wed, Oct 30, 2013 at 08:35:04AM +0100, Takashi Iwai wrote:

> +	if (channel < 0)
> +		return channel;
>  	BUG_ON(channel > 1);

This doesn't seem to fit in well with the adjacent code - the handling
of out of bounds data isn't consistent though it looks like they're both
doing essentially the same thing here.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20131030/548fe81e/attachment.sig>

More information about the Alsa-devel mailing list