[alsa-devel] [PATCH 9/9] ASoC: wm8996: Fix negative array index read

Mark Brown broonie at kernel.org
Wed Oct 30 17:51:03 CET 2013

On Wed, Oct 30, 2013 at 08:35:07AM +0100, Takashi Iwai wrote:

>  	int block = wm8996_get_retune_mobile_block(kcontrol->id.name);
> +	if (block < 0)
> +		return block;
>  	ucontrol->value.enumerated.item[0] = wm8996->retune_mobile_cfg[block];

Applied, but this only fixes some of the problem - there's nothing
validating that block is in bounds for the array, this now adds code
which validates the lower but not upper bound for this.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20131030/8fa1a1bc/attachment.sig>

More information about the Alsa-devel mailing list