[alsa-devel] [PATCH 7/9] ASoC: ml26124: Fix negative array index read

Mark Brown broonie at kernel.org
Wed Oct 30 17:48:38 CET 2013

On Wed, Oct 30, 2013 at 08:35:05AM +0100, Takashi Iwai wrote:

>  	int i = get_coeff(priv->mclk, params_rate(hw_params));
> +	if (i < 0)
> +		return -EINVAL;

This is ignoring the supplied error code, I'd expect to see the error
code being passed back (and fixed at the point where it's injected if
it's just returning -1 or something).
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20131030/1cfb664a/attachment.sig>

More information about the Alsa-devel mailing list