[alsa-devel] [PATCH 2/9] ASoC: ab8500: Add missing return in ab8500_codec_set_dai_fmt()

Takashi Iwai tiwai at suse.de
Wed Oct 30 08:35:00 CET 2013

Otherwise you'll see unrelated error message, too.

Spotted by coverity CID 715173.

Signed-off-by: Takashi Iwai <tiwai at suse.de>
 sound/soc/codecs/ab8500-codec.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/sound/soc/codecs/ab8500-codec.c b/sound/soc/codecs/ab8500-codec.c
index 6e3dda1ca734..0693faf7effb 100644
--- a/sound/soc/codecs/ab8500-codec.c
+++ b/sound/soc/codecs/ab8500-codec.c
@@ -2132,6 +2132,7 @@ static int ab8500_codec_set_dai_fmt(struct snd_soc_dai *dai, unsigned int fmt)
 			"%s: ERROR: The device is either a master or a slave.\n",
+		return -EINVAL;
 			"%s: ERROR: Unsupporter master mask 0x%x\n",

More information about the Alsa-devel mailing list