[alsa-devel] [PATCH] ASoC: tegra: Remove redundant initialisation of compat_filter_fn

Lars-Peter Clausen lars at metafoo.de
Tue Oct 22 13:40:18 CEST 2013

On 10/20/2013 11:38 PM, Stephen Warren wrote:
> On 10/19/2013 02:17 PM, Mark Brown wrote:
>> From: Mark Brown <broonie at linaro.org>
>> Setting a field in a static struct to NULL has no effect so don't bother
>> (and don't generate false positives for grep).
> I'm fine with this either way, so feel free to take my ack whichever way
> you work this out with Lars-Peter.

I don't care that much either, just wanted to give an explanation why things
are the way they are. Mark, if you want to merge this patch you can add:
Acked-by: Lars-Peter Clausen <lars at metafoo.de>

Btw. wasn't there a plan to move tegra to the generic dma bindings? If not I
think it might be a good idea to add the possibility to let the DMA  driver
overwrite the DT attribute parsing done by of_dma_match_channel(). This
would spare drivers from having to do the parsing manually and it would
allow the tegra pcm driver to just follow the normal OF path in the
generic-dmaengine-pcm driver and didn't had to rely on the compat path.

- Lars

More information about the Alsa-devel mailing list