[alsa-devel] [Kernel-BR] Re: [PATCH] sound: pci: emu10k1: code refactoring and casting removal
Raphael S Carvalho
raphael.scarv at gmail.com
Thu Oct 17 20:35:46 CEST 2013
> 2013/10/17 Takashi Iwai <tiwai at suse.de>:
>> Geyslan, you don't have to waste too much of your time (and my time
>> for review) for this kind of so old driver code unless it really fixes
>> the bugs. A clean up is good in general, but it can be sometimes
>> worse than nothing since it also breaks the history, thus makes hard
>> to follow via "git blame", for example, and of course, there is always
>> a potential danger of regression.
>> So, if it's about clean up, do it only in a systematic way that others
>> can follow easily, and don't do it too intensively.
His code refactoring proposal is welcome since the old code sucks from
several points of view, e.g. maintainability, legibility, etc.
Yes, of course, it's important to be careful in order not to introduce
regressions. And yes, he could improve something here and there.
As long as changes improve the maintainability and legibility of the
code, there is no reason to refuse them.
Raphael S. Carvalho
More information about the Alsa-devel